Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Sentiment Analysis - Language from corpus #954

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Mar 10, 2023

Derived from #874

Description of changes

Use language from the corpus for Sentiment analysis

This PR also fix some other problems:

  • Widget run computation in a separate thread to prevent blocking of widget
  • Offline errors had to be re-implemented (widget does not check available languages on start anymore) since it can trigger the download of models which block the widget. Now models are downloaded before sentiment is computed in the separate thread.
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title [ENH] Sentiment Analysis - language from corpus [ENH] Sentiment Analysis - Language from corpus Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #954 (2531c33) into master (9bd6012) will increase coverage by 0.20%.
The diff coverage is 92.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
+ Coverage   77.79%   78.00%   +0.20%     
==========================================
  Files          87       87              
  Lines       12302    12282      -20     
  Branches     1613     1609       -4     
==========================================
+ Hits         9570     9580      +10     
+ Misses       2433     2413      -20     
+ Partials      299      289      -10     

@PrimozGodec PrimozGodec force-pushed the language-sentiment branch 3 times, most recently from 0d008a2 to dacbb7a Compare March 10, 2023 14:54
@PrimozGodec PrimozGodec marked this pull request as draft March 24, 2023 07:53
@PrimozGodec PrimozGodec marked this pull request as ready for review March 31, 2023 06:39
@VesnaT VesnaT merged commit 9a72fc0 into biolab:master Apr 21, 2023
@PrimozGodec PrimozGodec deleted the language-sentiment branch April 21, 2023 12:05
@PrimozGodec PrimozGodec restored the language-sentiment branch April 21, 2023 12:05
@PrimozGodec PrimozGodec deleted the language-sentiment branch April 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants