Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Keywords: Fix selection and use idClicked instead of buttonClicked #965

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Issue
Traceback (most recent call last):
...
  File "../orange3-text/orangecontrib/text/widgets/owkeywords.py", line 270, in <lambda>
    callback=lambda: self._set_selection_method(
TypeError: OWKeywords._set_selection_method() takes 1 positional argument but 2 were given

When making a widget PyQt6 compatible in #929, I missed a callback causing the issue.

Description of changes

Also at that time, I didn't know that buttonClicked[int] was removed on behalf of idClicked. So instead of changing the callback I am reverting the _set_selection_method to the previous state and using idClicked callback instead.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #965 (db09218) into master (9a72fc0) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
+ Coverage   77.91%   78.14%   +0.22%     
==========================================
  Files          87       87              
  Lines       12299    12299              
  Branches     1613     1613              
==========================================
+ Hits         9583     9611      +28     
+ Misses       2423     2402      -21     
+ Partials      293      286       -7     

@PrimozGodec PrimozGodec force-pushed the fix-selection-keywords branch from 0c212f0 to 4eece2f Compare April 24, 2023 07:17
@PrimozGodec PrimozGodec force-pushed the fix-selection-keywords branch from 4eece2f to db09218 Compare April 24, 2023 07:21
@PrimozGodec PrimozGodec marked this pull request as ready for review April 24, 2023 07:26
@lanzagar lanzagar self-assigned this Apr 24, 2023
@lanzagar lanzagar changed the title Keywords - fix selection and use idClicked instead of buttonClicked [FIX] Keywords: Fix selection and use idClicked instead of buttonClicked Apr 24, 2023
@lanzagar lanzagar merged commit 9557862 into biolab:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants