[FIX] import_documents - replace lxml xml parser with ElementTree #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
replace-lxml
branch
4 times, most recently
from
02f3fdb to
b173adc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 78.16% 78.13% -0.03%
==========================================
Files 87 87
Lines 12321 12319 -2
Branches 1613 1614 +1
==========================================
- Hits 9631 9626 -5
- Misses 2405 2406 +1
- Partials 285 287 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #974
lxmllibrary is used only in importing documents to read XML files. They still didn't provide MacOS ARM wheels (Apple silicon), so installing text add-ons for users with Apple Silicon without certain compilers fails.Description of changes
Since there exists an ElemntTree alternative to read XML, I propose replacing lxml. ElementTree is considered fast since it uses fast c implementation and it comes with python. I see a situation as a good way to eliminate one dependency.
Includes