Playlist improvements #269
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function to request a file path from the playlist. Needed since we do not make the playlist itself directly accessible.
These test files check malloc, realloc and dealloc calls from the new playlist system with a mock file system.
Rebase on dev finished. Applied automatic code formatting and removed duplicated test code, fix warning and reomve prototype code and unused queues.
laszloh
force-pushed
the
feature/playlist_improvements
branch
from
21d3617 to
67f90a7
Compare
Aquire the lock before making write access to the gPlayProperties.
tueddy
reviewed
Nov 30, 2023
| @@ -22,6 +24,14 @@ inline bool isNumber(const char *str) { | |||
| } | |||
| } | |||
|
|
|||
| inline const char *getPath(File &f) { | |||
| if constexpr (ESP_ARDUINO_VERSION_MAJOR >= 2) { | |||
There was a problem hiding this comment.
This is obsolete, we are on Arduino >=2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the playlist generation to use C++ std::vector and std::string with a custom allocator (preferring the PSRAM if available) to create the file list.
For an extended discussion about the features and class hierarchy, see: https://forum.espuino.de/t/vorstellung-playlist-optimierung/1890/11