improved serving of small and large (tested ~1Mb) cover images #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SZenglein
force-pushed
the
improve_serve_coverimg
branch
from
4bc601e to
949fda7
Compare
|
I've tested with my coverart folder (30 different mp3s) and every image is shown with these changes. |
|
Can you provide an example file to reproduce the issue? |
SZenglein
force-pushed
the
improve_serve_coverimg
branch
from
949fda7 to
a477563
Compare
SZenglein
force-pushed
the
improve_serve_coverimg
branch
from
a477563 to
ef75dfe
Compare
|
I've tested your sample file with FF, Safari, Chrome & i cannot see any issues with current implementation: Your approach seems also slower providing the coverimage. Any ideas to reproduce your issues? |
|
Weird. It happened the most on Firefox Android, maybe you can try that. It was a big issue for me, because opening the web page on my phone immediately blocked the core where AsyncTCP is running, crashing everything running there. |
|
OK, i'll try again with android + FF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some problems with pretty large mp3 covers. Initially I tought it was another AudioLib issue, but with these changes it works very smoothly, albeit slowly