Implement Dockerization #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If testing from this branch (before it's merged), the Dockerfile needs to be modified to replace with |
cthoyt
reviewed
Oct 14, 2021
cthoyt
force-pushed
the
dockerize
branch
2 times, most recently
from
8d3f9ca to
eb0397b
Compare
Rather than including detach by default, I added a note below.
The --version got added in master but should be able to print out this info The --host option should also be available
|
In case anybody is looking at this later, I tried to pilot this myself and ran into all sorts of issues with permissions making it difficult for git inside docker to use the credentials from my host file system... we're putting this one on hold for the time being, since getting this working might be more complicated than the current setup with python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a dockerization for Biomappings. This allows users to perform curations for Biomappings without having to have a Python environment and Biomappings installed on the host machine. In the default scenario, the user merely needs to provide a
GITHUBUSERenvironment variable to the one-linedocker runcommand to ensure that curations are pushed to an appropriate fork to which the user has write access.@cthoyt could you test this and see if it works for you as well? I also think we should have more flexible ways to set an ORCID to apply to curations, and tie that into this approach (e.g., allow the user to specify it as a -e argument for docker run).