Use xscen new #427
Use xscen new #427
Conversation
for more information, see https://pre-commit.ci
|
Local run of test suite are struggling triggering pull request to see test failures. |
Conflicts: finch/processes/ensemble_utils.py
for more information, see https://pre-commit.ci
…nto use_xscen_new Conflicts: finch/processes/ensemble_utils.py
for more information, see https://pre-commit.ci
|
@aulemahal @Zeitsperre ... any idea why I get a permission error for |
|
I really can't see why... All the other tests pass and they do the same thing... It passes successfully on my machine. I do get the notebook failures, but the OpenDAP links in the log work in a standalone console... |
|
@tlogan2000 Hypothèse : the issue stems from temporary directories. I switched most (all?) temp file handling in the tests to use pytest's functions instead of custom ones. The notebook error were coming from a faulty In details : we were making a HEAD request on the "raw" URL. OpenDAP does not specify what the server should return when hitting the pure dataset url without any query. Thredds v4 was returning something, v5 is returning an error. My solution is to request the "metadata" of the dataset using the ".dds" "query", which is something all OpenDAP server should be able to do. |
|
Changing the temp dir methods didn't work, but dropping python 3.9 did. Any reasons not to, @Zeitsperre ? I think finch is solely used by ClimateData and through it's docker image which installs python 3.12 by default I think. |
|
@aulemahal Dropping Python3.9 is fine. We've already done this in recent versions of |
|
This is just waiting on an update to the changelog. Thanks again! |
Overview
This PR fixes [issue id]
Changes:
Related Issue / Discussion
Additional Information
Links to other issues or sources.