[bitnami/keycloak] Update KEYCLOAK_ADMIN env variables deprecation #30636
Conversation
Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead Bump major version Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
|
Sorry, duplicate of #30635, it was starting to get messy for such small changes |
Signed-off-by: Bitnami Containers <[email protected]>
javsalgar
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Hi @singatias
KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD are the actual values used by the Bitnami Keycloak container image, see:
Why is this change necessary? In case they're necessary due to upstream changes, we should start by adapting the container image 1st.
Hi @juan131, they are not necessary yet but they are already marked as deprecated so I took proactive decision make the changes. You are correct about making changes for the container image first container PR https://www.keycloak.org/docs/26.0.6/upgrading/#external-infinispan-in-a-single-site-setup I'm still new to participate in big open source repository, let me know if there things I can improve on :) |
There was a problem hiding this comment.
Thank you for your contribution @singatias, could you please take a look at my comment?
…jor version Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Sorry @singatias but we lost track of this PR, please ensure you merge the latest changes in the origin's |
|
@juan131 np, thank you for this learning experience |
…min-envs-deprecation-patch Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
|
done :) |
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
Minor changes to change KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD environment and secret variables to update to the new values KC_BOOTSTRAP_ADMIN_USERNAME, KC_BOOTSTRAP_ADMIN_PASSWORD
Benefits
remove deprecation message and reduce the upcoming maintenance when the env variables will be removed
Possible drawbacks
the new variables env could be invalid on a an older keycloak image
Applicable issues
none
Additional information
I notice the deprecation messages on my new instance of keycloak and decided to make the changes since they were minor
I could be wrong about bumping the major version of the chart, but technically, if someone upgrades their Keycloak instance using an older overridden version of the Keycloak image from before the environment variables were changed, it could be defective. Let me know if this need to be change or feel free to edit it before merging.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm