-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/etcd] Add pre-upgrade hook #31161
Open
pckhoi
wants to merge
6
commits into
bitnami:main
Choose a base branch
from
pckhoi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+262
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khoi Pham <[email protected]>
Signed-off-by: Khoi Pham <[email protected]>
Thanks for your contribution!! Just so you know, to run our test suite, separate PRs per chart must be created. In this case, two different PRs are required: one for common and another one for etcd. |
Sure, I have just created this one: #31164 |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
4 tasks
carrodher
added
etcd
verify
Execute verification workflow for these changes
in-progress
labels
Dec 27, 2024
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
preupgrade.sh
- a new script added in [bitnami/etcd] Stop relying on files for state containers#75906removeMemberOnContainerTermination
parameterinitialClusterState
parameterBenefits
Benefits are described more extensively in bitnami/containers#75906 but here are the main points:
initialClusterState
parameterPossible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm