[bitnami/Ghost] Correctly handle smtpExistingSecret value #31179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Correctly handles setting either
.Values.smtpPassword
or.Values.smtpExistingSecret
. Default smtp-password is now created in its own Secret if an existing is not provided.Benefits
Fixes the need to provide a dummy
smtpPassword
value when using an external secret.Possible drawbacks
The SMTP secret, if an existing Secret resource is not provided, is now in its own Secret resource rather than the one used for the Ghost auth credentials (to be more in-line with the database secret)
Applicable issues
smtpExistingSecret
value is ignored #8916Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm