-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[binatmi/schema-registry] Add support for Amazon MSK IAM auth #74014
Conversation
Signed-off-by: Bela Pesics <[email protected]>
Hi @bpesics, Thank you very much for your contribution! Before I can accept this feature, I would need to ask you about the following information:
I'm sorry but without that information, this would need to remain as a customization on users' side. |
We could accept adding support for the |
I think the support of additional authentication mechanisms is an implicit consequence of SASL support.
The SASL mechanism can be selected by I'd also point out that I think the users of this Bitnami image most probably aren't subscribers of the Confluent platform (otherwise they'd use the image
As |
@migruiz4 @carrodher is there anything more I can do to get this merged? |
I encountered a similar issue with Google Cloud Managed Kafka and proposed a provider-agnostic solution in #74972. I believe the best way to support additional |
@michalmisiewicz Nice, thanks for the heads-up! Your PR addressed what I refer to here as "client authentication" issue.
Thanks! Your PR addressed what I referred to here as "client authentication" issue, that should simplify things. On the other hand, |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
Add Amazon MSK IAM authentication support.
Benefits
Allows Schema Registry to use AWS IAM for authentication and authorization against Amazon MSK clusters that have AWS IAM enabled as an authentication mechanism. This is obviously more desired than no authentication or plain text with static credentials.
Possible drawbacks
N/A
Applicable issues
Additional information
As a side issue, this image insisted on mounting a keystore file for any
SECURITY_PROTOCOL
which includesSSL
orSASL
, presumably for TLS client authentication.In order to avoid breaking the existing behaviour I added
SCHEMA_REGISTRY_KAFKASTORE_CLIENT_AUTH_DISABLED
to provide a way to disable validation when mounting keystore files isn't really necessary.