Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/clickhouse] fix startup issue when using json logs #75308 #75309

Conversation

jesusnavaso
Copy link
Contributor

Description of the change

I am changing the text we look for in clickhouse startup logs to check that clickhouse started in the background correctly when we are going to run start o init scripts.

Benefits

JSON is the most standard format for logging. With this change, we can use json logs and start scripts at the same time

Possible drawbacks

There is an edge case still not covered. If you intentally left the message field out of the JSON logs, the application will fail to start even with this fix, but it would be extremely rare for someone to enable json logs and manually omit the message field to produce useless logs.

I added a warning about this possibility in the section of the README that talks about the init/start scripts

Applicable issues

Additional information

@jesusnavaso
Copy link
Contributor Author

@carrodher This is my first collaboration in Open Source in GitHub, so please tell me which procedures I am missing or doing wrong.
Thanks beforehand.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 2, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 2, 2024
@github-actions github-actions bot removed the request for review from carrodher December 2, 2024 11:23
@github-actions github-actions bot requested a review from jotamartos December 2, 2024 11:23
@jotamartos
Copy link
Contributor

Hi @jesusnavaso,

Thank you for taking the time to contribute. The PR is completely valid, but the changes in the .sh scripts are not necessary. Could you please take a look at it and provide an example where that output doesn't appear in the log file?

Thanks

jotamartos
jotamartos previously approved these changes Dec 19, 2024
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@jotamartos
Copy link
Contributor

jotamartos commented Dec 19, 2024

Hi @jesusnavaso,

It seems your branch is outdated and it's generating conflicts. You basically need to remove the changes in the 24.3 and 24.8 folders. Could you please update it and update the PR so we can merge it?

@jotamartos jotamartos force-pushed the bugfix/clickhouse_startup_fail_using_json_logs branch from ef23b54 to 4ce5981 Compare December 19, 2024 12:01
@jotamartos jotamartos enabled auto-merge (squash) December 19, 2024 12:02
@jotamartos jotamartos merged commit 166737e into bitnami:main Dec 19, 2024
11 checks passed
@jesusnavaso jesusnavaso deleted the bugfix/clickhouse_startup_fail_using_json_logs branch December 19, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clickhouse solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickhouse container fails to start if there are init/start scripts when JSON logs are enabled.
3 participants