-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/clickhouse] fix startup issue when using json logs #75308 #75309
[bitnami/clickhouse] fix startup issue when using json logs #75308 #75309
Conversation
@carrodher This is my first collaboration in Open Source in GitHub, so please tell me which procedures I am missing or doing wrong. |
bitnami/clickhouse/24.3/debian-12/rootfs/opt/bitnami/scripts/libclickhouse.sh
Outdated
Show resolved
Hide resolved
Hi @jesusnavaso, Thank you for taking the time to contribute. The PR is completely valid, but the changes in the .sh scripts are not necessary. Could you please take a look at it and provide an example where that output doesn't appear in the log file? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
bitnami/clickhouse/24.3/debian-12/rootfs/opt/bitnami/scripts/libclickhouse.sh
Outdated
Show resolved
Hide resolved
Hi @jesusnavaso, It seems your branch is outdated and it's generating conflicts. You basically need to remove the changes in the 24.3 and 24.8 folders. Could you please update it and update the PR so we can merge it? |
Signed-off-by: Jesus Navas Orozco <[email protected]>
ef23b54
to
4ce5981
Compare
Description of the change
I am changing the text we look for in clickhouse startup logs to check that clickhouse started in the background correctly when we are going to run start o init scripts.
Benefits
JSON is the most standard format for logging. With this change, we can use json logs and start scripts at the same time
Possible drawbacks
There is an edge case still not covered. If you intentally left the
message
field out of the JSON logs, the application will fail to start even with this fix, but it would be extremely rare for someone to enable json logs and manually omit the message field to produce useless logs.I added a warning about this possibility in the section of the README that talks about the init/start scripts
Applicable issues
Additional information