-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
journal doesnt work anymore #75699
base: main
Are you sure you want to change the base?
journal doesnt work anymore #75699
Conversation
Signed-off-by: Jevgeny Fedorovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jfshark,
As that parameter is no longer supported, could you please update the .sh scripts and remove the mongodb_set_journal_conf function and MONGODB_ENABLE_JOURNAL env var?
Thanks
Hi @jotamartos, I would do it, but I am afraid I am not competent enough for this. I simply followed the approach used in this PR, which was accepted and resolved the issue for v7. If there were related changes in another PR or commit, please let me know its ID, and I will incorporate them into my PR as well. |
The changes are as easy removing these lines (and the entire mongodb_set_journal_conf function)
Can you do that? |
I did. But FYI same issue is in mongodb-sharded chart. Also I see the variable MONGODB_DEFAULT_ENABLE_JOURNAL in 8.0/debian-12/rootfs/opt/bitnami/scripts/mongodb-env.sh, which looks somehow related. |
Correct, but the mongodb-sharded container shares the same logic with mongodb. Once we merge your changes, mongodb-sharded will be updated too.
Yes, you will need to remove those references too. Regarding the issues in the tests, you will find how to solve the DCO test clicking on the Details button. |
Same as the #65826 but for 8 version of mongodb