Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journal doesnt work anymore #75699

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

journal doesnt work anymore #75699

wants to merge 2 commits into from

Conversation

jfshark
Copy link

@jfshark jfshark commented Dec 11, 2024

Same as the #65826 but for 8 version of mongodb

Signed-off-by: Jevgeny Fedorovich <[email protected]>
@github-actions github-actions bot added mongodb triage Triage is needed labels Dec 11, 2024
@github-actions github-actions bot requested a review from carrodher December 11, 2024 17:12
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 11, 2024
@github-actions github-actions bot removed the request for review from carrodher December 11, 2024 20:16
@github-actions github-actions bot requested a review from jotamartos December 11, 2024 20:16
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jfshark,

As that parameter is no longer supported, could you please update the .sh scripts and remove the mongodb_set_journal_conf function and MONGODB_ENABLE_JOURNAL env var?

Thanks

@jfshark
Copy link
Author

jfshark commented Dec 17, 2024

Hi @jfshark,

As that parameter is no longer supported, could you please update the .sh scripts and remove the mongodb_set_journal_conf function and MONGODB_ENABLE_JOURNAL env var?

Thanks

Hi @jotamartos,

I would do it, but I am afraid I am not competent enough for this. I simply followed the approach used in this PR, which was accepted and resolved the issue for v7. If there were related changes in another PR or commit, please let me know its ID, and I will incorporate them into my PR as well.

@jotamartos
Copy link
Contributor

The changes are as easy removing these lines (and the entire mongodb_set_journal_conf function)

➜  mongodb git:(main) ag MONGODB_ENABLE_JOURNAL
8.0/debian-12/rootfs/opt/bitnami/scripts/mongodb-env.sh
40:    MONGODB_ENABLE_JOURNAL
126:export MONGODB_ENABLE_JOURNAL="${MONGODB_ENABLE_JOURNAL:-}"

8.0/debian-12/rootfs/opt/bitnami/scripts/libmongodb.sh
493:            if [[ -n "$MONGODB_ENABLE_JOURNAL" ]]; then
494:                mongodb_conf="$(sed -E "/^ *journal:/,/^ *[^:]*:/s/enabled:.*/enabled: $({ is_boolean_yes "$MONGODB_ENABLE_JOURNAL" && echo 'true'; } || echo 'false')/" "$conf_file_path")"

README.md
190:| `MONGODB_ENABLE_JOURNAL`                | Enable MongoDB journal                                                                                                                         | `nil`                               |
355:* `MONGODB_ENABLE_JOURNAL`: Whether to enable/disable journaling on MongoDB&reg;. Default: `true`. Possible values: `[true, false]`
358:docker run --name mongodb -e ALLOW_EMPTY_PASSWORD=yes -e MONGODB_ENABLE_JOURNAL=true bitnami/mongodb:latest
369:      - MONGODB_ENABLE_JOURNAL=true
➜  mongodb git:(main) ag mongodb_set_journal_conf
8.0/debian-12/rootfs/opt/bitnami/scripts/libmongodb.sh
482:mongodb_set_journal_conf() {
1428:    mongodb_set_journal_conf "$MONGODB_CONF_FILE"

Can you do that?

@jfshark
Copy link
Author

jfshark commented Dec 17, 2024

The changes are as easy removing these lines (and the entire mongodb_set_journal_conf function)

➜  mongodb git:(main) ag MONGODB_ENABLE_JOURNAL
8.0/debian-12/rootfs/opt/bitnami/scripts/mongodb-env.sh
40:    MONGODB_ENABLE_JOURNAL
126:export MONGODB_ENABLE_JOURNAL="${MONGODB_ENABLE_JOURNAL:-}"

8.0/debian-12/rootfs/opt/bitnami/scripts/libmongodb.sh
493:            if [[ -n "$MONGODB_ENABLE_JOURNAL" ]]; then
494:                mongodb_conf="$(sed -E "/^ *journal:/,/^ *[^:]*:/s/enabled:.*/enabled: $({ is_boolean_yes "$MONGODB_ENABLE_JOURNAL" && echo 'true'; } || echo 'false')/" "$conf_file_path")"

README.md
190:| `MONGODB_ENABLE_JOURNAL`                | Enable MongoDB journal                                                                                                                         | `nil`                               |
355:* `MONGODB_ENABLE_JOURNAL`: Whether to enable/disable journaling on MongoDB&reg;. Default: `true`. Possible values: `[true, false]`
358:docker run --name mongodb -e ALLOW_EMPTY_PASSWORD=yes -e MONGODB_ENABLE_JOURNAL=true bitnami/mongodb:latest
369:      - MONGODB_ENABLE_JOURNAL=true
➜  mongodb git:(main) ag mongodb_set_journal_conf
8.0/debian-12/rootfs/opt/bitnami/scripts/libmongodb.sh
482:mongodb_set_journal_conf() {
1428:    mongodb_set_journal_conf "$MONGODB_CONF_FILE"

Can you do that?

I did. But FYI same issue is in mongodb-sharded chart.

Also I see the variable MONGODB_DEFAULT_ENABLE_JOURNAL in 8.0/debian-12/rootfs/opt/bitnami/scripts/mongodb-env.sh, which looks somehow related.
Also in Readme
| MONGODB_DEFAULT_ENABLE_JOURNAL | Enable MongoDB journal at build time |

@jotamartos
Copy link
Contributor

I did. But FYI same issue is in mongodb-sharded chart.

Correct, but the mongodb-sharded container shares the same logic with mongodb. Once we merge your changes, mongodb-sharded will be updated too.

Also I see the variable MONGODB_DEFAULT_ENABLE_JOURNAL in 8.0/debian-12/rootfs/opt/bitnami/scripts/mongodb-env.sh, which looks somehow related.

Yes, you will need to remove those references too.

Regarding the issues in the tests, you will find how to solve the DCO test clicking on the Details button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress mongodb verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants