Added the Helm chart for the Secrets Manager operator #123

jhbeskow · 2024-03-05T14:33:16Z

Initial creation of the Helm chart for Secrets Manager operator.

bitwarden-bot · 2024-03-05T14:34:57Z

Checkmarx One – Scan Summary & Details – 8f32dabb-ab87-4ab1-98ed-f775c50df4f2

New Issues

Issue	Source File / Package	Checkmarx Insight
Passwords And Secrets - Generic Password	/tests.yml: [117](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/tests.yml# L117)	Query to find passwords and secrets in infrastructure code.
Unpinned Actions Full Length Commit SHA	/update-versions-self-host.yml: [27](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions-self-host.yml# L27)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-self-host.yml: [23](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-self-host.yml# L23)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/tests.yml: [38](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/tests.yml# L38)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-sm-operator.yml: [47](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-sm-operator.yml# L47)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/update-versions-self-host.yml: [131](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions-self-host.yml# L131)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/update-versions-self-host.yml: [52](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions-self-host.yml# L52)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-self-host.yml: [96](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-self-host.yml# L96)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-self-host.yml: [39](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-self-host.yml# L39)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-sm-operator.yml: [30](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-sm-operator.yml# L30)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-self-host.yml: [103](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-self-host.yml# L103)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/version-bump-self-host.yml: [111](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump-self-host.yml# L111)	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Passwords And Secrets - Generic Password	/tests.yml: [103](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/tests.yml# L103)
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: [23](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump.yml# L23)
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: [96](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump.yml# L96)
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: [103](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump.yml# L103)
	Unpinned Actions Full Length Commit SHA	/update-versions.yml: [52](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions.yml# L52)
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: [39](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump.yml# L39)
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: [111](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/version-bump.yml# L111)
	Unpinned Actions Full Length Commit SHA	/update-versions.yml: [131](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions.yml# L131)
	Unpinned Actions Full Length Commit SHA	/update-versions.yml: [27](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//.github/workflows/update-versions.yml# L27)
	Container Requests Not Equal To It's Limits	/web.yaml: [56](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/web.yaml# L56)
	Container Requests Not Equal To It's Limits	/events.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/events.yaml# L70)
	Container Requests Not Equal To It's Limits	/admin.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/admin.yaml# L70)
	Container Requests Not Equal To It's Limits	/identity.yaml: [72](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/identity.yaml# L72)
	Container Requests Not Equal To It's Limits	/attachments.yaml: [56](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/attachments.yaml# L56)
	Container Requests Not Equal To It's Limits	/api.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/api.yaml# L70)
	Container Requests Not Equal To It's Limits	/notifications.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/notifications.yaml# L70)
	Container Requests Not Equal To It's Limits	/sso.yaml: [72](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/sso.yaml# L72)
	Container Requests Not Equal To It's Limits	/icons.yaml: [81](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/icons.yaml# L81)
	Container Requests Not Equal To It's Limits	/events.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/events.yaml# L70)
	Container Requests Not Equal To It's Limits	/sso.yaml: [72](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/sso.yaml# L72)
	Container Requests Not Equal To It's Limits	/identity.yaml: [72](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/identity.yaml# L72)
	Container Requests Not Equal To It's Limits	/api.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/api.yaml# L70)
	Container Requests Not Equal To It's Limits	/notifications.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/notifications.yaml# L70)
	Container Requests Not Equal To It's Limits	/admin.yaml: [70](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/admin.yaml# L70)
	Container Requests Not Equal To It's Limits	/web.yaml: [56](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/web.yaml# L56)
	Container Requests Not Equal To It's Limits	/icons.yaml: [81](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/icons.yaml# L81)
	Container Requests Not Equal To It's Limits	/mssql.yaml: [37](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/mssql.yaml# L37)
	Container Requests Not Equal To It's Limits	/attachments.yaml: [56](https://github.com/bitwarden/helm-charts/blob/features/sm-operator-chart//charts/self-host/templates/attachments.yaml# L56)

…e have in the other chart

…lows for multiple charts.

…re to include any test files and the README

… These are the only ones we have static binaries for.

Fix

coltonhurst

Overall looks pretty good, though I am not super familiar with Helm charts, so just a couple questions / whitespace kind of things.

.github/workflows/tests.yml

.github/workflows/update-versions-sm-operator.yml

charts/sm-operator/.helmignore

charts/sm-operator/values.schema.json

charts/sm-operator/values.yaml

joseph-flinn

I'll approve in @vgrassia's stead since he's OOO tomorrow

tangowithfoxtrot · 2024-06-07T12:09:30Z

I didn't see that auto-merge was enabled for this.

jhbeskow · 2024-06-07T13:16:12Z

I didn't see that auto-merge was enabled for this.

This was my fault. I was afraid this would get reviewed while I am out. @coltonhurst, if you see anything that still needs to be fixed, let me know today, and I will knock it out.

coltonhurst · 2024-06-07T19:18:28Z

No worries at all @jhbeskow @tangowithfoxtrot

Looks good, thanks for the hard work :)

jhbeskow added 3 commits March 4, 2024 18:04

Added the Helm chart for the Secrets Manager operator

64e0def

Some formatting changes requested by GitHub

b1f81df

Adding end-of-file carriage return suggested by GitHub

459e7cf

jhbeskow temporarily deployed to Production March 5, 2024 14:37 — with GitHub Actions Inactive

jhbeskow temporarily deployed to Production March 5, 2024 14:47 — with GitHub Actions Inactive

differsthecat requested review from tangowithfoxtrot and coltonhurst March 5, 2024 14:59

jhbeskow added 3 commits March 7, 2024 11:58

Removing the schema definition from the schema itself to match what w…

b6b4070

…e have in the other chart

Merge branch 'main' into features/sm-operator-chart

4b4732b

Fixing an issue with the identity URL override

7c400ed

jhbeskow temporarily deployed to Production March 8, 2024 18:59 — with GitHub Actions Inactive

README and CRD description updates.

bdc13b0

jhbeskow temporarily deployed to Production March 14, 2024 22:02 — with GitHub Actions Inactive

Updating to use GHCR

3148bfb

jhbeskow temporarily deployed to Production March 26, 2024 19:35 — with GitHub Actions Inactive

Adding optional image pull secrets

51f2454

jhbeskow temporarily deployed to Production March 26, 2024 21:55 — with GitHub Actions Inactive

Adding missing properties to the values schema

cc057d1

jhbeskow temporarily deployed to Production March 26, 2024 22:07 — with GitHub Actions Inactive

jhbeskow added 3 commits March 29, 2024 08:57

Adding sm-operator to the build. Differentiating the versioning workf…

3949495

…lows for multiple charts.

Fixing sed statement for appVersion lookup

1df830a

Adding the operator README to the root readme. Updating the .helmigno…

72296b3

…re to include any test files and the README

jhbeskow temporarily deployed to Production April 1, 2024 16:33 — with GitHub Actions Inactive

jhbeskow requested a review from joseph-flinn April 1, 2024 21:53

Adding Dev Container for testing purposes.

958c15e

jhbeskow temporarily deployed to Production April 5, 2024 19:38 — with GitHub Actions Inactive

Locking down affinity to only the architectures we currently support.…

5c34fff

… These are the only ones we have static binaries for.

jhbeskow had a problem deploying to Production June 5, 2024 18:44 — with GitHub Actions Failure

jhbeskow marked this pull request as ready for review June 5, 2024 18:45

jhbeskow requested review from a team as code owners June 5, 2024 18:45

Fixing the tag on the test values file

1586345

jhbeskow temporarily deployed to Production June 5, 2024 18:56 — with GitHub Actions Inactive

jhbeskow had a problem deploying to Production June 5, 2024 18:56 — with GitHub Actions Failure

jhbeskow enabled auto-merge (squash) June 5, 2024 18:59

Reverting the removal of imagePullSecrets for now to test

b83dbb7

jhbeskow temporarily deployed to Production June 5, 2024 19:10 — with GitHub Actions Inactive

vgrassia previously approved these changes Jun 6, 2024

View reviewed changes

coltonhurst reviewed Jun 6, 2024

View reviewed changes

Updates requested from PR

a628132

jhbeskow dismissed vgrassia’s stale review via a628132 June 6, 2024 21:30

jhbeskow temporarily deployed to Production June 6, 2024 21:30 — with GitHub Actions Inactive

jhbeskow requested review from coltonhurst and vgrassia June 6, 2024 21:31

joseph-flinn approved these changes Jun 7, 2024

View reviewed changes

tangowithfoxtrot approved these changes Jun 7, 2024

View reviewed changes

jhbeskow merged commit 42435d8 into main Jun 7, 2024
6 checks passed

jhbeskow deleted the features/sm-operator-chart branch June 7, 2024 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the Helm chart for the Secrets Manager operator #123

Added the Helm chart for the Secrets Manager operator #123

jhbeskow commented Mar 5, 2024

bitwarden-bot commented Mar 5, 2024 •

edited

Loading

coltonhurst left a comment

joseph-flinn left a comment

tangowithfoxtrot commented Jun 7, 2024

jhbeskow commented Jun 7, 2024

coltonhurst commented Jun 7, 2024

Added the Helm chart for the Secrets Manager operator #123

Added the Helm chart for the Secrets Manager operator #123

Conversation

jhbeskow commented Mar 5, 2024

bitwarden-bot commented Mar 5, 2024 • edited Loading

New Issues

Fixed Issues

coltonhurst left a comment

Choose a reason for hiding this comment

joseph-flinn left a comment

Choose a reason for hiding this comment

tangowithfoxtrot commented Jun 7, 2024

jhbeskow commented Jun 7, 2024

coltonhurst commented Jun 7, 2024

bitwarden-bot commented Mar 5, 2024 •

edited

Loading