[PM-7621] Add better control on annotations and labels on deployments and pods #135
Conversation
Signed-off-by: Frédéric Marchand <[email protected]>
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
bitwarden-bot
added
in-product-review
|
No New Or Fixed Issues Found |
| annotations: | ||
| {{- include "bitwarden.annotations" . | indent 4 }} |
There was a problem hiding this comment.
This should be moved up near line 8 where the current annotations key is defined.
There was a problem hiding this comment.
It looks like this may have been missed. The ingress.yaml file has two annotations keys. Line 21 should be deleted and Line 22 should be moved above line 12.
Signed-off-by: Frédéric Marchand <[email protected]>
|
Thanks, I have corrected |
| {{ include "bitwarden.labels" . | indent 8 }} | ||
| {{ include "bitwarden.podLabels" . | indent 8 }} | ||
| {{- with .Values.component.identity.podLabels }} | ||
| {{ toYaml . | indent 4 }} |
There was a problem hiding this comment.
| {{ toYaml . | indent 4 }} | |
| {{ toYaml . | indent 8 }} |
| annotations: | ||
| {{- include "bitwarden.annotations" . | indent 4 }} |
There was a problem hiding this comment.
It looks like this may have been missed. The ingress.yaml file has two annotations keys. Line 21 should be deleted and Line 22 should be moved above line 12.
|
|
This PR allows better control on annotations and labels assigned to deployments and pods.