Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-35347: Add REST endpoint to retrieve synonym sources from index mapping #20

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Oct 16, 2023

  • This endpoint allows users to retrieve the names of synonym sources defined in an
    index mapping, enhancing accessibility and configurability for synonym-related features.

@CascadingRadium CascadingRadium changed the title MB-35347: Synonym Search MB-35347: Add REST endpoint to fetch synonym sources from index mapping Nov 6, 2024
@CascadingRadium CascadingRadium removed the request for review from moshaad7 November 6, 2024 10:02
@CascadingRadium CascadingRadium changed the title MB-35347: Add REST endpoint to fetch synonym sources from index mapping MB-35347: Add REST endpoint to retrieve synonym sources from index mapping Dec 12, 2024
@abhinavdangeti abhinavdangeti merged commit 7ffc723 into master Dec 12, 2024
@abhinavdangeti abhinavdangeti deleted the MB-35347 branch December 12, 2024 16:43
@abhinavdangeti
Copy link
Member

@CascadingRadium Use v0.5.4 for this commit.

@CascadingRadium
Copy link
Member Author

this must have been merged after the bleve merge 😅 since this requires uses

	synonymSources := make([]string, 0, indexMapping.SynonymCount())
	for name := range indexMapping.CustomAnalysis.SynonymSources {

the necessary APIs are there in the still open bleve PR
will open another PR updating the go.mod here later

@abhinavdangeti
Copy link
Member

Gotcha. Let's not use v0.5.4 then. We'll set up a new version after the go.mod patching.

@abhinavdangeti
Copy link
Member

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants