Skip to content

Commit

Permalink
Remove unnecessary additional lookup
Browse files Browse the repository at this point in the history
Disable workflows on macos
  • Loading branch information
abhinavdangeti committed Dec 17, 2024
1 parent 83855c1 commit 214122b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
go-version: [1.20.x, 1.21.x, 1.22.x]
platform: [ubuntu-latest, macos-latest, windows-latest]
platform: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.platform }}
steps:
- name: Install Go
Expand Down
2 changes: 1 addition & 1 deletion index/scorch/snapshot_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ var DefaultFieldTFRCacheThreshold int = 0 // disabled because it causes MB-64604

func (i *IndexSnapshot) getFieldTFRCacheThreshold() int {
if i.parent.config != nil {
if _, exists := i.parent.config["fieldTFRCacheThreshold"]; exists {
if val, exists := i.parent.config["fieldTFRCacheThreshold"]; exists {

Check failure on line 572 in index/scorch/snapshot_index.go

View workflow job for this annotation

GitHub Actions / test (1.20.x, ubuntu-latest)

val declared and not used

Check failure on line 572 in index/scorch/snapshot_index.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, ubuntu-latest)

val declared and not used

Check failure on line 572 in index/scorch/snapshot_index.go

View workflow job for this annotation

GitHub Actions / test (1.22.x, ubuntu-latest)

val declared and not used
val := i.parent.config["fieldTFRCacheThreshold"]
if x, ok := val.(float64); ok {
// JSON unmarshal-ed into a map[string]interface{} will default
Expand Down

0 comments on commit 214122b

Please sign in to comment.