feat: remove sloppy math for sin, cos and asin #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the LUT implementation for `sin`, `cos` and `asin`. For `sin` and `cos` they are not faster than the hardware provided `sin` and `cos` instructions on AMD64 and ARM64. For `asin` LUT does seem to be a bit faster but hardware and LUT implementation are both in the same order of magnitude for performance and `asin` LUT unconditionally takes 1.5MiB of memory which seems a bit excessive.
abhinavdangeti
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
|
Thank you for this contribution @Gusted . |
abhinavdangeti
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the LUT implementation for
sin,cosandasin. Forsinandcosthey are not faster than the hardware providedsinandcosinstructions on AMD64 and ARM64. ForasinLUT does seem to be a bit faster but hardware and LUT implementation are both in the same order of magnitude for performance andasinLUT unconditionally takes 1.5MiB of memory which seems a bit excessive.If the usage of
asinis really performance sensitive (I'm not that familiar with the geo library) it might be better to lazy-load this LUT to avoid users of the bleve library that don't have a use of the geo library to inherit this 1.5MiB of memory.