-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presearch Code Refactor #2112
Presearch Code Refactor #2112
Conversation
- Refactor the presearch code path to make it more generic and extensible.
8b10cdf
to
d58474f
Compare
my bad, rebased (to the latest master) but pushed on the wrong branch :p |
@CascadingRadium, so I looked into the bm25 code and realized that we are going to aggregate a field specific stat as well. in your synonyms code, i see you've written a query tree parser
can you refactor that to two sets of APIs one generic one which returns all the fields in the query and synonyms can use that API in ExtractSynonyms and bm25 can also use this API to fetch those field specific stat and that API you can push it to this refactor branch |
Put a |
-or- if you think we merge this first and rebase #2090 that's fine too. |
i think we can merge this and rebase the #2090 on top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for one more review perhaps. Also @CascadingRadium hope you've made sure all the knn tests still succeed with this change.
This is useful when an alias contains partitions of the same index, as the index
mapping would be consistent across all indexes and can be inferred directly from
the alias.