WIP: upgrade to arrow 2.0 #83
Draft
+178
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validated has been deprecated, and is no longer included in Arrow.
This patch backports ValidatedNel as an alias of an underlying type, and maintains the existing extensions.
Continuations have been deprecated in favour of the Raise DSL. I have removed OutcomeEagerEffect scope, as the Raise DSL does not expose an eager implementation to be extend. Instead, the expectation is that the caller wraps calls in `eagerEffect`. This binds the suspended function to an eager context.
|
|
|
Awesome seeing this @hugomd 👏 👏 I'm a bit busy during KotlinConf, but during the summer we're going to work hard relaxing 2.0.0 (final). I will regularly check in here how things are going, but if you come across anything weird please let me know, and tag me and I'll be happy to help in whatever way I can |
nomisRev
reviewed
May 21, 2024
Comment on lines
16
to
19
| // TODO(hugom): move this into an effect package, instead of continuations to align with arrow (?) | ||
| @JvmInline | ||
| value class OutcomeEagerEffectScope<E>(private val cont: EagerEffectScope<Either<Failure<E>, Absent>>) : | ||
| EagerEffectScope<Either<Failure<E>, Absent>> { | ||
| value class OutcomeEffectScope<E>(private val cont: Raise<Either<Failure<E>, Absent>>) : | ||
| Raise<Either<Failure<E>, Absent>> { |
There was a problem hiding this comment.
I think this can be removed, I contributed a Raise impl last year in the raise package.
There was a problem hiding this comment.
Awesome! I'll look at migrating some of our existing codebases over to OutcomeRaise and see how it works out before removing 👍🏻
kotest-extensions-arrow has not yet been upgrade to arrow 2.0.0, so we're seeing compatibility issues with some of the older implementations. In the meantime, we can add our own Arb to make tests pass.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
OutcomeEffectScopeis sufficient in-place ofOutcomeEagerEffectScope. I believe this no longer enforces non-suspending functionsquiverTraverseNotes
Please see arrow-kt/arrow#2778