Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample app that uses Compose. #53

Merged
merged 3 commits into from
Aug 22, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Aug 20, 2020

Based on #50.

Note that Compose is still not supported, but having this sample in place
ensures that we keep the build working for Compose going forward.

Screenshot_1597988083

Example of output for an app that has a Compose view with a nested Android view:

com.squareup.radiography.sample.compose.MainActivity:
window-focus:false
 DecorView { 1080×2160px }
 +-LinearLayout { 1080×2028px }
 | +-ViewStub { id:action_mode_bar_stub, GONE, 0×0px }
 | `-FrameLayout { 1080×1962px }
 |   `-FitWindowsLinearLayout { id:action_bar_root,
 |     +-ViewStubCompat { id:action_mode_bar_stub, GONE,
 |     `-ContentFrameLayout { id:content, 1080×1962px }
 |       `-AndroidComposeView { 770×425px, focused }
 |         `-AndroidViewsHandler { 770×425px }
 |           `-ViewBlockHolder { 160×53px }
 |             `-TextView { 160×53px, text-length:9 }
 +-View { id:navigationBarBackground, 1080×132px }
 `-View { id:statusBarBackground, 1080×66px }

This will get better in #33!

This PR is 3 commits:

  1. Run UI tests on all PRs, not just ones targeting main.
  2. Add the sample app.
  3. Add smoke UI tests to both the new sample app and the existing one to ensure they launch.

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/compose-sample branch from a829d44 to 5ae1bdd Compare August 20, 2020 20:08
@zach-klippenstein zach-klippenstein changed the base branch from main to zachklipp/restrict-stdlib-1.3 August 20, 2020 20:09
@zach-klippenstein zach-klippenstein marked this pull request as ready for review August 20, 2020 20:09
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/compose-sample branch 3 times, most recently from ad619e5 to 35dfc41 Compare August 20, 2020 20:40
Base automatically changed from zachklipp/restrict-stdlib-1.3 to main August 21, 2020 04:41
This is necessary for stacked PRs.
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/compose-sample branch from 35dfc41 to 4184165 Compare August 21, 2020 05:16
Note that Compose is still not supported, but having this sample in place
ensures that we keep the build working for Compose going forward.

Example of output for an app that has a Compose view:

```
com.squareup.radiography.sample.compose.MainActivity:
window-focus:false
 DecorView { 1080×2160px }
 +-LinearLayout { 1080×2028px }
 | +-ViewStub { id:action_mode_bar_stub, GONE, 0×0px }
 | `-FrameLayout { 1080×1962px }
 |   `-FitWindowsLinearLayout { id:action_bar_root,
 |     +-ViewStubCompat { id:action_mode_bar_stub, GONE,
 |     `-ContentFrameLayout { id:content, 1080×1962px }
 |       `-AndroidComposeView { 770×425px, focused }
 |         `-AndroidViewsHandler { 770×425px }
 |           `-ViewBlockHolder { 160×53px }
 |             `-TextView { 160×53px, text-length:9 }
 +-View { id:navigationBarBackground, 1080×132px }
 `-View { id:statusBarBackground, 1080×66px }
```
@zach-klippenstein
Copy link
Collaborator Author

The red shard actually passed, it just failed to upload the success report.

Copy link
Contributor

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing these in the wrong order! Oh well.

I already miss the 🥖

@zach-klippenstein zach-klippenstein merged commit 78e2db3 into main Aug 22, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/compose-sample branch August 22, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants