This repository has been archived by the owner on Mar 9, 2023. It is now read-only.
0.2 hibernate #39
Open
0.2 hibernate #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With more stricter ordering and resending of messages, the protocol for negotiating a new channel status can get simplified. As resending lost messages means that a started exchange can not be aborted anymore, we can already define the next revocation hash at the end of the current exchange. With a known revocation hash, the initiator can directly send signatures for the update. Also, LNPaymentProcessor and LNPaymentLogic have been made less stateful with relying on the database as single source of truth. This means that much logic has been moved into the DBHandler.
NodeKey is a wrapper around ECKey that does allow comparing the same ECKey. ECKey.equals is generally not reliable, as it also compares the createDate of the key.
When both parties send a request to update the channel concurrently, there was a problem that could have led to loss of funds. We now send a fresh revocation hash to be used for the next exchange at the beginning of the exchange (with the A message), such that in case of a conflict, we can use that unused revocation hash directly to construct the new status.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.