Add lookup-methods post-action for solidity verifier #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenzing
reviewed
Nov 16, 2023
smart-contract-verifier/smart-contract-verifier-server/src/services/solidity_verifier.rs
Outdated
Show resolved
Hide resolved
sevenzing
reviewed
Nov 16, 2023
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| match s { | ||
| "lookup-methods" => Ok(VerifyPostAction::LookupMethods), |
There was a problem hiding this comment.
please add this option to comment on this protobuf field. It will make this field appear in comment in swagger
There was a problem hiding this comment.
It was added in the previous PR
There was a problem hiding this comment.
@sevenzing What is your suggestion instead of kebab-case?
sevenzing
reviewed
Nov 16, 2023
smart-contract-verifier/smart-contract-verifier-server/tests/solidity_types.rs
Outdated
Show resolved
Hide resolved
rimrakhimov
reviewed
Nov 16, 2023
smart-contract-verifier/smart-contract-verifier-server/src/services/solidity_verifier.rs
Outdated
Show resolved
Hide resolved
smart-contract-verifier/smart-contract-verifier/src/lookup_methods/find_methods.rs
Outdated
Show resolved
Hide resolved
smart-contract-verifier/smart-contract-verifier/src/lookup_methods/find_methods.rs
Outdated
Show resolved
Hide resolved
smart-contract-verifier/smart-contract-verifier/src/lookup_methods/find_methods.rs
Outdated
Show resolved
Hide resolved
smart-contract-verifier/smart-contract-verifier-server/src/services/solidity_verifier.rs
Outdated
Show resolved
Hide resolved
smart-contract-verifier/smart-contract-verifier-server/src/types/verify_response.rs
Outdated
Show resolved
Hide resolved
Comment on lines
21
to
24
| pub fn find_methods_from_compiler_output( | ||
| contract_name: &String, | ||
| output: &CompilerOutput, | ||
| ) -> anyhow::Result<LookupMethodsResponse> { |
There was a problem hiding this comment.
I'm not sure if that would be easier and better overall, but as an option, we may also get all required data from the compilation_artifacts, deployed_code_artifacts and local_bytecode_parts
There was a problem hiding this comment.
As these fields are stored as raw JSON values we have to clone and parse them. Not sure about this approach
lok52
force-pushed
the
lok52/lookup-methods-verify
branch
from
ff7b6e7 to
6adbcca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookup-methodspost-action handler for solidity verifier service.