Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HEALTH] Extract health endpoint definition into blockscout-health crate #894

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

rimrakhimov
Copy link
Member

@rimrakhimov rimrakhimov commented May 26, 2024

Extract health proto and actix-prost definition builds into a separate lib. That allows not to add health endpoints into api_config_http.yaml and not to specfy that #[serde(default)] field attribute for .grpc.health.v1.HealthCheckRequest.service in each service.

As a downside, the health endpoint would be missing from the resultant swagger.

Implemented as a separate crate, because we need a build.rs script to explicitly build only those definitions

@rimrakhimov rimrakhimov changed the base branch from main to rimrakhimov/visualizer/extract-health May 26, 2024 20:06
Base automatically changed from rimrakhimov/visualizer/extract-health to main May 27, 2024 11:59
@rimrakhimov rimrakhimov requested a review from sevenzing July 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants