Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented an interpretation stub for failed transactions #2373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+50 −1
Open

Implemented an interpretation stub for failed transactions #2373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions .idea/frontend.iml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion ui/pages/Transaction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,24 @@ const TransactionPageContent = () => {
if (isCustomAppError(error)) {
throwOnResourceLoadError({ resource: 'tx', error, isError: true });
}
}
} else {
// Display a specific failure message for failed transactions
return (
<div>
<TextAd mb={ 6 }/>
<PageTitle
title="Transaction details"
backLink={ backLink }
contentAfter={ tags }
secondRow={ titleSecondRow }
/>
<p style={{ color: 'red', fontWeight: 'bold', marginTop: '20px' }}>
Address failed to call method on address.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! It's not exactly what the issue is about.
The idea was to implement a stub for transaction with a failed status, not an error state of the page.
Also, it has to be not the plain text, but addresses and method name from the transaction data.
And we use chakra-ui and variables for colors and paddings, so styling is not correct also

</p>
</div>
);
}
}

return (
<>
Expand Down