Remove independent check of horizon #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this to work without hitches, we need to make it more robust. 1) It should be on some kind of worker that will keep polling horizon for a set amount of time, in case the horizon instance is lagging 2) It should be on a worker so that it does not block the web workers If the horizon server that the user is checking against is lagging, then there will be some callbacks that will be ignored.
ramontayag
force-pushed
the
remove_independent_horizon_check
branch
from
aa9512f to
51e33b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work without hitches, we need to make it more robust. Better to remove it until fixes are addressed because when the horizon server that the user is checking against is lagging, then there will be some callbacks that will be ignored.