-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: Add support to leak detection #66
src: Add support to leak detection #66
Conversation
f7fb109
to
aa5567e
Compare
@patrickelectric Does it worked on your Rpi? Try use the same method as SPI pins instead. |
It does work, did you run as sudo ? It's required for hardware access. |
aa5567e
to
00192c3
Compare
I just moved the pin initialization now to be done by the init call |
Signed-off-by: Patrick José Pereira <[email protected]>
00192c3
to
7346a28
Compare
didn't, the spi method pins doesn't require it, if we require sudo - we will need to pass this requirement for users under all the other libraries. |
can you try the latest version ? |
Seems fine for self-hosted runner, Can you add : |
@@ -332,6 +334,8 @@ impl NavigatorBuilder { | |||
|
|||
let led = Led::new(); | |||
|
|||
let leak = Pin::new(27); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Define leakage sensor Pin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by it ? I'm following the same pattern as in the LED initialization. It's already clear that 27 is the pin for the leak detection in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to have some overall explanation, which sensor.
The LEDs are self-explained, but leakage sensors need to attach an extra gadget to GPIO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to have some overall explanation, which sensor. The LEDs are self-explained, but leakage sensors need to attach an extra gadget to GPIO.
That's documented on the read_leak function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
Signed-off-by: Patrick José Pereira <[email protected]>
0d867be
to
46cbac0
Compare
No description provided.