rework drivers #83
Merged
rework drivers #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
rework
branch
4 times, most recently
from
3f000a2 to
b2285fc
Compare
RaulTrombin
requested changes
Nov 23, 2024
There was a problem hiding this comment.
Quick-tests were changed to run on self-hosted CI, it's feature that's only available inside BR, and takes from 20~30 minutes to a rpi compile it from zero.
Some features were removed: self_test, read_all.
Benchmark output is different from the shown on PR.
The newer structure still can't handle the case where we have multiple PeripheralClasses, such the second Magnetometer, PWM0 (rpi one) and BR bars
| if approx::relative_eq!(duty_cycle, 1.0) { | ||
| self.pwm.set_channel_full_on(channel.into(), 0).unwrap(); | ||
| return; | ||
| fn get_magnetometer_sensor(&mut self) -> Option<&mut dyn MagnetometerSensor> { |
There was a problem hiding this comment.
How the newer API will handle the second Magnetometer?
There was a problem hiding this comment.
It'll return a vector of an option
patrickelectric
commented
Nov 25, 2024
|
|
||
| self.set_led(select, !state) | ||
| } | ||
| devices: Vec<Box<dyn AnyHardware>>, |
There was a problem hiding this comment.
Keep in mind to investigate map in the future
joaoantoniocardoso
approved these changes
Nov 25, 2024
patrickelectric
force-pushed
the
rework
branch
9 times, most recently
from
646e981 to
2806c56
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
rework
branch
from
2806c56 to
6c5ef57
Compare
|
@RaulTrombin all comments are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major rework that: