FIX: If resource_path is absolute, patch it up on the way out #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase. |
mrakitin
reviewed
Jul 30, 2019
tacaswell
force-pushed
the
fix_export_with_abs_rpath
branch
from
9857979 to
0bb96d0
Compare
|
rebased, git failed to track moving everything to |
|
Looks like a real test failure related to this PR: https://travis-ci.org/bluesky/databroker/jobs/569966262#L1208 |
|
Bump |
- do not insert an invalid resource with both a non-trivial root and an absolute resource_path
tacaswell
force-pushed
the
fix_export_with_abs_rpath
branch
from
157072b to
2e77b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an absolute resource_path
attn @CJ-Wright
No test because I am racing the train into jamacia!