Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug, found by @genematx:
We had unit-tested
c['arr'].data_sources()
but did not have a test covering callingdata_sources()
directly on the object return bywrite_array(...)
, in the case whereinclude_data_sources=True
had not been set on the client and thus the data sources needed to be fetched.This PR adds a unit test for that case, which reproduces the bug and fails. It then adds a fix.
Checklist
Add the ticket number which this PR closes to the comment section