Reintroduce deprecated cka api for compatibility #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannik-dittmar
approved these changes
Nov 22, 2023
src/key.cpp
Outdated
| const std::vector<uint8_t> &keyID, | ||
| const HsmKeyParams ¶ms) | ||
| { | ||
| // libp11 uses 128 byte buffer |
There was a problem hiding this comment.
As someone with very little knowledge about this software I'm a bit confused what this comment should tell me... Is this the limiting factor for the key size and if yes why? Do you think it would make sense to describe it with one or two more words and also change the comment in line 234/294/314?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the API using HsmKeyParams that was removed in #156 . We want to keep it around and then remove it in a subsequent release.