-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prebuilt binaries through Github actions #159
base: master
Are you sure you want to change the base?
Conversation
124cb6f
to
46b2291
Compare
Verified that it is able to compile the binaries: https://github.com/qwertzguy/node-heapdump/pull/1/checks?sha=0fa0b311158c85ba142ec335e9bace9a5c7ff415 For it to work, it requires a maintainer to create a github token: https://www.npmjs.com/package/prebuild#create-github-token and then add it in the Settings tab of the repo > Secrets > Name: GITHUB_TOKEN. It should then run when a new tag starting with the letter "v" is pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Just one question.
Let me know if you're ready to merge this. After merging, you would need to follow the steps from my previous comment to setup the github token. |
Hi @bnoordhuis Is it possible to give me write access to be able to merge this? Or can you merge it? |
Could you make it prebuild for alpine also? (or is it already?) |
Sorry for the delay. I got stuck back then trying to figure out how to scope the personal access token to a single repo. Anyone know if that's possible? |
You can create a "machine user": https://docs.github.com/en/developers/overview/managing-deploy-keys#machine-users |
I'd really appreciate getting this across the finish line (along with docs showing how to use it). I'm trying to figure out an apparent memory leak that's only reproducing on prod. Anything I can do to help? The machine user solution looks good to me. |
This reverts commit 84d522c. bnoordhuis/node-heapdump#159
It requires a maintainer to do the steps I outlined in the 2nd comment. |
This reverts commit 84d522c5a6475a24eca0448778d1af4562dcac80. bnoordhuis/node-heapdump#159
This reverts commit 84d522c. bnoordhuis/node-heapdump#159
Resolves #152