Ensure we don't break when removing (mulitple) Relations out of order

bolt · Sep 25, 2023 · 2ee6927 · 2ee6927
1 parent 8a00997
commit 2ee6927
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/Controller/Backend/ContentEditController.php b/src/Controller/Backend/ContentEditController.php
@@ -629,9 +629,11 @@ static function (Relation $relation) use ($content) {
                 $currentRelations
                     ->first(
                         static function (Relation $relation) use ($id) {
+                            $fromId = $relation->getFromContent() ? $relation->getFromContent()->getId() : null;
+                            $toId = $relation->getToContent() ? $relation->getToContent()->getId() : null;
                             return \in_array(
                                 $id,
-                                [$relation->getFromContent()->getId(), $relation->getToContent()->getId()],
+                                [$fromId, $toId],
                                 true
                             );
                         }

diff --git a/src/Entity/ContentExtrasTrait.php b/src/Entity/ContentExtrasTrait.php
@@ -12,7 +12,7 @@
  */
 trait ContentExtrasTrait
 {
-    /** @var ContentExtension */
+    /** @var ContentExtension|null */
     private $contentExtension;
 
     public function setContentExtension(ContentExtension $contentExtension): void

diff --git a/src/Entity/Relation.php b/src/Entity/Relation.php
@@ -106,7 +106,7 @@ public function setPosition(int $position): self
         return $this;
     }
 
-    public function getFromContent(): Content
+    public function getFromContent(): ?Content
     {
         return $this->fromContent;
     }
@@ -116,7 +116,7 @@ public function setFromContent($content): void
         $this->fromContent = $content;
     }
 
-    public function getToContent(): Content
+    public function getToContent(): ?Content
     {
         return $this->toContent;
     }