Smaller: Remind them to use refactorings catalog

Also add some links to list of code smells and corresponding refactorings.
booch · Apr 21, 2017 · 3371c3a · 3371c3a
1 parent 59ee45e
commit 3371c3a
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 8 deletions.
diff --git a/Smaller/TODO.md b/Smaller/TODO.md
@@ -1,8 +1,6 @@
 TODO
 ====
 
-* Remind them to use https://refactoring.com/catalog/
-
 * Pictures of MVP thin vertical slices
 * Picture of Feasible, Valuable, Usable, Delightful
 * Pull in Joe's slides 78-79

diff --git a/Smaller/slides.html b/Smaller/slides.html
@@ -162,8 +162,9 @@
         max-height: 400px;
         border: 1px solid black;
       }
-      .remark-slide .remark-slide-content.workshop > p {
-        margin-top: 180px;
+      .remark-slide .remark-slide-content.workshop > p:first-of-type {
+        margin-top: 100px;
+        margin-bottom: 100px;
         text-align: center;
       }
       .remark-slide .remark-slide-content .highlight {
@@ -612,6 +613,9 @@
 
 -----
 
+* Good lists of smells and the corresponding refactorings:
+    * https://sourcemaking.com/refactoring/smells
+    * http://www.industriallogic.com/wp-content/uploads/2005/09/smellstorefactorings.pdf
 * There are also "design smells" for problems with higher-level designs
     * These usually require restructuring that is NOT refactoring
 * Coined by Kent Beck in 1999
@@ -739,8 +743,9 @@
 
 # When Am I Done Refactoring?
 
-* When code is as clear as possible
 * You're likely **not** overdoing it
+* When code is as clear as possible
+* When there are no more smells
 * When every method is 1 line long
     * Preferably with no `if`s
 * When you meet the Sandi Metz metrics
@@ -925,6 +930,15 @@
 
 https://github.com/boochtek/aatc2017
 
+Don't forget to use these resources:
+* https://refactoring.com/catalog/
+* https://sourcemaking.com/refactoring/smells
+
+???
+
+* Pair (or triple) up and work the exercises at this URL
+* I'll walk around to help answer questions
+
 ---
 class: thanks
 

diff --git a/Smaller/slides.html.erb b/Smaller/slides.html.erb
@@ -162,8 +162,9 @@
         max-height: 400px;
         border: 1px solid black;
       }
-      .remark-slide .remark-slide-content.workshop > p {
-        margin-top: 180px;
+      .remark-slide .remark-slide-content.workshop > p:first-of-type {
+        margin-top: 100px;
+        margin-bottom: 100px;
         text-align: center;
       }
       .remark-slide .remark-slide-content .highlight {

diff --git a/Smaller/slides.md b/Smaller/slides.md
@@ -437,6 +437,9 @@ Catalog of refactorings: https://refactoring.com/catalog/
 
 -----
 
+* Good lists of smells and the corresponding refactorings:
+    * https://sourcemaking.com/refactoring/smells
+    * http://www.industriallogic.com/wp-content/uploads/2005/09/smellstorefactorings.pdf
 * There are also "design smells" for problems with higher-level designs
     * These usually require restructuring that is NOT refactoring
 * Coined by Kent Beck in 1999
@@ -564,8 +567,9 @@ Catalog of refactorings: https://refactoring.com/catalog/
 
 # When Am I Done Refactoring?
 
-* When code is as clear as possible
 * You're likely **not** overdoing it
+* When code is as clear as possible
+* When there are no more smells
 * When every method is 1 line long
     * Preferably with no `if`s
 * When you meet the Sandi Metz metrics
@@ -750,6 +754,15 @@ class: workshop
 
 https://github.com/boochtek/aatc2017
 
+Don't forget to use these resources:
+* https://refactoring.com/catalog/
+* https://sourcemaking.com/refactoring/smells
+
+???
+
+* Pair (or triple) up and work the exercises at this URL
+* I'll walk around to help answer questions
+
 ---
 class: thanks