Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ test: Today Statistic Test 작성 #252

Merged
merged 8 commits into from
Dec 2, 2024
Merged

✅ test: Today Statistic Test 작성 #252

merged 8 commits into from
Dec 2, 2024

Conversation

Jo-Minseok
Copy link
Collaborator

@Jo-Minseok Jo-Minseok commented Dec 2, 2024 •
edited
Loading

🔨 테스크

Issue

DTO 테스트 분리

  • 입력 값에 대해서 E2E 테스트를 하는 게 맞을까? 싶었다.
  • 팀내에서 입력값에 대해서는 DTO 테스트로 별도 분리하자는 의견이 나와서 이 의견에 따르기로 했다.

📋 작업 내용

  • rssAccept Fixture 속성 이름 변경
  • dto 테스트 분리
  • today 테스트 이름들 컨벤션에 맞추기
  • today 테스트 given, when, then 패턴 적용

📷 스크린 샷(선택 사항)

테스트 결과

@Jo-Minseok Jo-Minseok requested a review from asn6878 December 2, 2024 08:52
@Jo-Minseok Jo-Minseok self-assigned this Dec 2, 2024
@Jo-Minseok Jo-Minseok requested a review from CodeVac513 December 2, 2024 08:52
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit ccd32af
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/674d86f6bd1d950008faab11

asn6878
asn6878 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CodeVac513
CodeVac513 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@CodeVac513 CodeVac513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jo-Minseok Jo-Minseok merged commit 7f40bea into main Dec 2, 2024
1 check passed
@Jo-Minseok Jo-Minseok deleted the test/today-statistic-api branch December 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn6878 asn6878 asn6878 approved these changes

@CodeVac513 CodeVac513 CodeVac513 approved these changes

Assignees

@Jo-Minseok Jo-Minseok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 일일 조회수 통계 API 구현
3 participants
@Jo-Minseok @CodeVac513 @asn6878