Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: 차트 컴포넌트 구현, 차트 API연동 #253

Merged
merged 11 commits into from
Dec 2, 2024
Merged

✨ feat: 차트 컴포넌트 구현, 차트 API연동 #253

merged 11 commits into from
Dec 2, 2024

Conversation

jungmyunggi
Copy link
Collaborator

🔨 테스크

Issue

작업중에 main에서 pull을 해서 파일 체인지가 많습니다. 고려해서 읽어주세요

mainContent와 Chart컴포넌트를 tap상태로 구분하여 랜더링

  • 라우팅을 사용하지 않고 가볍게 차트를 가져오기 위해서 상태를 두고 각각 랜더링을 진행하기 위해 tap이라는 전역상태를 만들었습니다.

📋 작업 내용

  • barChart, pieChart 구현
  • Chart컴포넌트 구현
  • 차트 API연동

📷 스크린 샷

image

@jungmyunggi jungmyunggi added the ✨ Feature 기능 구현 label Dec 2, 2024
@jungmyunggi jungmyunggi requested a review from junyeokk December 2, 2024 09:04
@jungmyunggi jungmyunggi self-assigned this Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit b92357f
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/674d891a3ba275000817542f

junyeokk
junyeokk reviewed Dec 2, 2024
View reviewed changes
client/src/hooks/queries/useChart.ts Outdated Show resolved Hide resolved
client/src/pages/Home.tsx Show resolved Hide resolved
junyeokk
junyeokk reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@junyeokk junyeokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@jungmyunggi jungmyunggi merged commit 0302197 into main Dec 2, 2024
1 check passed
@jungmyunggi jungmyunggi deleted the feat/chart branch December 2, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junyeokk junyeokk junyeokk approved these changes

Assignees

@jungmyunggi jungmyunggi

Labels
✨ Feature 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] 통계 API연동 [FE] 통계 컴포넌트 UI구현
2 participants
@jungmyunggi @junyeokk