Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: FeedController, FeedService 리팩토링 #257

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

CodeVac513
Copy link
Collaborator

@CodeVac513 CodeVac513 commented Dec 2, 2024

🔨 테스크

Issue

📋 작업 내용

  • FeedController와 FeedService의 메서드 이름을 네이밍 컨벤션에 따라 수정했습니다.
  • 메서드별로 파일을 나누고 네이밍 컨벤션에 따라 swagger 데코레이터를 수정했습니다.
  • service 계층에 있던 DB 접근 관련 로직이 repository 계층 내에서 수행되도록 수정했습니다.

@CodeVac513 CodeVac513 added 📝 Docs 문서화 작업 🔨 Refactor 리팩토링 (구조 변경) 🧹 Cleanup 코드 정리 labels Dec 2, 2024
@CodeVac513 CodeVac513 self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit 0354b67
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/674f40264c4ae8000876c67e

@CodeVac513 CodeVac513 changed the title Refactor/feed structure ♻️ refactor: feedController, FeedService 리팩토링 Dec 2, 2024
@CodeVac513 CodeVac513 changed the title ♻️ refactor: feedController, FeedService 리팩토링 ♻️ refactor: FeedController, FeedService 리팩토링 Dec 2, 2024
Copy link
Collaborator

@Jo-Minseok Jo-Minseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 지울 부분 체크해뒀고 궁금한 부분 커멘트로 남겨뒀습니다! 확인 부탁드립니다.

server/src/feed/feed.service.ts Outdated Show resolved Hide resolved
server/src/feed/feed.repository.ts Outdated Show resolved Hide resolved
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!
민석님이 주신 피드백 확인해주시면 감사하겠습니다~

server/src/feed/feed.repository.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Jo-Minseok Jo-Minseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. DAO Repository 자체 함수들은 롤백 부탁드립니다.

server/src/feed/feed.service.ts Outdated Show resolved Hide resolved
@CodeVac513 CodeVac513 merged commit 89260cf into main Dec 3, 2024
1 check passed
@CodeVac513 CodeVac513 deleted the refactor/feed-structure branch December 4, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Cleanup 코드 정리 📝 Docs 문서화 작업 🔨 Refactor 리팩토링 (구조 변경)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants