Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: rss등록 모달 alert추가, 관리자 세션만료 확인버튼 이벤트 추가 #258

Merged
merged 2 commits into from
Dec 2, 2024
Merged

✨ feat: rss등록 모달 alert추가, 관리자 세션만료 확인버튼 이벤트 추가 #258

merged 2 commits into from
Dec 2, 2024

Conversation

jungmyunggi
Copy link
Collaborator

📋 작업 내용

  • rss등록 모달 alert추가
  • 관리자 세션만료 확인버튼 이벤트 추가

📷 스크린 샷

  • Rss 등록모달
    image

  • 세션만료 모달
    image

@jungmyunggi jungmyunggi added the ✨ Feature 기능 구현 label Dec 2, 2024
@jungmyunggi jungmyunggi requested a review from asn6878 December 2, 2024 14:07
@jungmyunggi jungmyunggi self-assigned this Dec 2, 2024
asn6878
asn6878 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영 감사합니다~
추후 꼭 고려해봐야 하는 점이 하나 생각나 남겨뒀어요.

일단은 이 버전대로 merge하고 나중에 수정해봅시다.

client/src/components/RssRegistration/RssRegistrationModal.tsx Show resolved Hide resolved
@jungmyunggi jungmyunggi merged commit 880db32 into main Dec 2, 2024
1 check passed
@jungmyunggi jungmyunggi deleted the feat/rss-alert branch December 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn6878 asn6878 asn6878 approved these changes

Assignees

@jungmyunggi jungmyunggi

Labels
✨ Feature 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jungmyunggi @asn6878