Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: redis์— ์บ์‹ฑ๋œ ์ตœ์‹  ํ”ผ๋“œ๊ฐ€ ์‚ญ์ œ๋˜์ง€ ์•Š๋Š” ๋ฒ„๊ทธ ์ˆ˜์ • #262

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

CodeVac513
Copy link
Collaborator

@CodeVac513 CodeVac513 commented Dec 2, 2024

๐Ÿ”จ ํ…Œ์Šคํฌ

Issue

๐Ÿ“‹ ์ž‘์—… ๋‚ด์šฉ

  • ์•„๋ž˜์ฒ˜๋Ÿผ ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ธฐ์กด์—๋Š” deleteRecentFeed()๊ฐ€ if ์กฐ๊ฑด๋ฌธ ๋‚ด๋ถ€์— ์žˆ์–ด์„œ ์ตœ์‹  ๊ฒŒ์‹œ๊ธ€์ด ์—ฐ์†์œผ๋กœ ๋‚˜์˜จ๋‹ค๋ฉด ์‚ญ์ œ๋˜์ง€ ์•Š๊ณ  ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.
    ์กฐ๊ฑด๋ฌธ ์™ธ๋ถ€๋กœ ๋นผ์„œ ํ•ญ์ƒ ์ง€์šธ ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  await deleteRecentFeed();
  if (result.length === 0) {
    logger.info("์ƒˆ๋กœ์šด ํ”ผ๋“œ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.");
    return;
  }
  • redis ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ•˜๋Š” ๊น€์— keys๊ฐ€ ์•„๋‹ˆ๋ผ scan์„ ํ†ตํ•ด์„œ ํ‚ค์— ์ ‘๊ทผํ•˜๊ณ  ์‚ญ์ œํ•  ์ˆ˜ ์žˆ๋„๋ก ๋กœ์ง์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ทธ๋ฆฌ๊ณ  let์œผ๋กœ ์„ ์–ธ๋œ ๋ณ€์ˆ˜์— ํƒ€์ž…์ด ๋ช…์‹œ๋  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ท ์Šคํฌ๋ฆฐ ์ƒท(์„ ํƒ ์‚ฌํ•ญ)

image

@CodeVac513 CodeVac513 added ๐Ÿ‘น BugFix ๋ฒ„๊ทธ ์ˆ˜์ • ๐Ÿ”จ Refactor ๋ฆฌํŒฉํ† ๋ง (๊ตฌ์กฐ ๋ณ€๊ฒฝ) ๐Ÿงน Cleanup ์ฝ”๋“œ ์ •๋ฆฌ labels Dec 2, 2024
@CodeVac513 CodeVac513 self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

โœ… Deploy Preview for denamu canceled.

Name Link
๐Ÿ”จ Latest commit 164b838
๐Ÿ” Latest deploy log https://app.netlify.com/sites/denamu/deploys/674dc72b7bf2b40008047042

@CodeVac513 CodeVac513 removed the ๐Ÿงน Cleanup ์ฝ”๋“œ ์ •๋ฆฌ label Dec 2, 2024
Copy link
Collaborator

@Jo-Minseok Jo-Minseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~ ๋‹ค์Œ๋ถ€ํ„ฐ๋Š” ์ž‘์—… ๋ธŒ๋žœ์น˜ ์‹ ๊ฒฝ์จ์ฃผ์„ธ์š”! PR์ด ๊ฒน์ณ์กŒ๋‹ค ๋ณด๋‹ˆ Redis ์บ์‹ฑ ์ตœ์‹  ํ”ผ๋“œ ์‚ญ์ œ ๋˜์ง€ ์•Š๋Š” ๋ฒ„๊ทธ ์ˆ˜์ • ๋ถ€๋ถ„๋งŒ ๋ณด๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ ์ด์ „ ์ž‘์—…์— ๋Œ€ํ•ด์„œ๋Š” ์ด์ „ PR์— ์ปค๋ฉ˜ํŠธ ๋‚จ๊ธฐ๋„๋ก ํ• ๊ฒŒ์š”~

Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ƒˆ์‚ผ ์‚ฌ์†Œํ•œ ๋กœ์ง ์‹ค์ˆ˜๊ฐ€ ์ด์ƒํ•œ ๋ฒ„๊ทธ๋กœ ์ด์–ด์ง„๋‹ค๋Š”๊ฒŒ ๋‹ค์‹œ๊ธˆ ๋Š๊ปด์ง€๋Š” PR์ด๋„ค์š” ใ… ใ… 

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค~

@CodeVac513 CodeVac513 merged commit 1fefa7d into main Dec 3, 2024
1 check passed
@CodeVac513 CodeVac513 deleted the fix/recent-feed-bugfix branch December 3, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ‘น BugFix ๋ฒ„๊ทธ ์ˆ˜์ • ๐Ÿ”จ Refactor ๋ฆฌํŒฉํ† ๋ง (๊ตฌ์กฐ ๋ณ€๊ฒฝ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants