-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: 소개 페이지 구현 #276
Merged
Merged
✨ feat: 소개 페이지 구현 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 메인 제목, 설명이 있는 HeroSection 추가 - 기능 카드들이 있는 FeatureSection 추가 - 추가적인 기능들이 있는 ExtraFeatureSection 추가 - 프로젝트 링크가 있는 Footer 추가
- 스크롤 기반 애니메이션을 구현하기 위해 useInView 추가 - progress indicator를 표시하기 위해 useScrollProgress 추가
Closed
14 tasks
jungmyunggi
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5) 혹시 첫 페이지에 바로가기 버튼이랑 사진 간격 조금만 줄일수있을까요? 너무 공백이 많아보이는 느낌이네요
jungmyunggi
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 남긴거 제외하고는 다 괜찮은거 같습니다. 코멘트 남긴것도 준혁님 판단 하에 처리해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 테스크
Issue
컴포넌트 구조 설계
UI/UX 개선 포인트
📋 작업 내용
페이지 레이아웃 구현
스크롤 인터랙션 구현
스크롤 프로그레스 표시
요소별 등장 애니메이션
📷 스크린 샷
스크롤 맨 위
Feature 소개
서비스 바로가기
Footer