Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance codebase line/branch coverage #17

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

poyenc
Copy link

@poyenc poyenc commented Aug 9, 2020

The goal of code coverage is 90%

@poyenc poyenc force-pushed the feature/enhance-code-coverage branch 4 times, most recently from bf853cc to 04e49e3 Compare August 10, 2020 01:38
@poyenc poyenc force-pushed the feature/enhance-code-coverage branch from 04e49e3 to 63102a7 Compare August 10, 2020 01:40
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #17 into develop will increase coverage by 21.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #17       +/-   ##
============================================
+ Coverage    70.95%   92.92%   +21.97%     
============================================
  Files            3        3               
  Lines          210      212        +2     
  Branches        74       66        -8     
============================================
+ Hits           149      197       +48     
+ Misses          18        0       -18     
+ Partials        43       15       -28     
Impacted Files Coverage Δ
include/boost/token_iterator.hpp 92.30% <ø> (+21.93%) ⬆️
include/boost/token_functions.hpp 93.33% <100.00%> (+22.14%) ⬆️
include/boost/tokenizer.hpp 83.33% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8a8bf...63102a7. Read the comment docs.

Copy link

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you break your changes into multiple commits? Each change should have a rational in their commit message.

The commit which adds the tests is OK.

Copy link
Collaborator

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and only include the test code changes, not the changes from #18. When I tried to do this I got four test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants