Features/subtensor #126

amitsingh19975 · 2021-06-21T05:32:39Z

No description provided.

github-actions

Reports by clang tidy

github-actions · 2021-06-21T06:08:09Z

test/tensor/test_access.cpp

+
+  fixture()
+  {
+    static_assert(shapes.size() == multi_index.size(),"");


use unary static_assert when the string literal is an empty string [modernize-unary-static-assert]

static_assert(shapes.size() == multi_index.size(),""); ^ ~~

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:09Z

test/tensor/test_access.cpp

+  fixture()
+  {
+    static_assert(shapes.size() == multi_index.size(),"");
+    static_assert(shapes.size() == indexf.size(),"");


use unary static_assert when the string literal is an empty string [modernize-unary-static-assert]

static_assert(shapes.size() == indexf.size(),""); ^ ~~

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:09Z

test/tensor/test_access.cpp

+  {
+    static_assert(shapes.size() == multi_index.size(),"");
+    static_assert(shapes.size() == indexf.size(),"");
+    static_assert(shapes.size() == indexl.size(),"");


use unary static_assert when the string literal is an empty string [modernize-unary-static-assert]

static_assert(shapes.size() == indexl.size(),""); ^ ~~

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:09Z

test/tensor/test_access.cpp

+    static_assert(shapes.size() == multi_index.size(),"");
+    static_assert(shapes.size() == indexf.size(),"");
+    static_assert(shapes.size() == indexl.size(),"");
+    static_assert(shapes.size() == ranks.size(),"");


use unary static_assert when the string literal is an empty string [modernize-unary-static-assert]

static_assert(shapes.size() == ranks.size(),""); ^ ~~

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:09Z

test/tensor/test_access.cpp

+  }
+
+
+  static inline auto shapes = std::array<extents_t,15>


15 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

static inline auto shapes = std::array<extents_t,15> ^

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:14Z

include/boost/numeric/ublas/tensor/subtensor.hpp

+	}
+
+	/** @brief Returns the span strides of the subtensor */
+  inline auto const& spans () const {


function spans should be marked [[nodiscard]] [modernize-use-nodiscard]

inline auto const& spans () const { ^ [[nodiscard]]

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:14Z

include/boost/numeric/ublas/tensor/subtensor.hpp

+};
+
+
+} // namespaces boost::numeric::ublas


namespace boost::numeric::ublas ends with an unrecognized comment [google-readability-namespace-comments]

} // namespaces boost::numeric::ublas ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ // namespace boost::numeric::ublas include/boost/numeric/ublas/tensor/subtensor.hpp:26:11: note: namespace 'boost::numeric::ublas' starts here namespace boost::numeric::ublas { ^

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:14Z

include/boost/numeric/ublas/tensor/subtensor_utility.hpp

+/// \file subtensor_utility.hpp Definition for the tensor template class
+
+#ifndef _BOOST_NUMERIC_UBLAS_TENSOR_SUBTENSOR_UTILITY_HPP_
+#define _BOOST_NUMERIC_UBLAS_TENSOR_SUBTENSOR_UTILITY_HPP_


declaration uses identifier _BOOST_NUMERIC_UBLAS_TENSOR_SUBTENSOR_UTILITY_HPP_, which is a reserved identifier [bugprone-reserved-identifier]

#define _BOOST_NUMERIC_UBLAS_TENSOR_SUBTENSOR_UTILITY_HPP_ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ BOOST_NUMERIC_UBLAS_TENSOR_SUBTENSOR_UTILITY_HPP_

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:14Z

include/boost/numeric/ublas/tensor/subtensor_utility.hpp

+
+  if constexpr ( is_sliced ){
+    if(size == 0)        return span_type(0       , extent0);
+    else if(first== max) return span_type(extent0 , extent0);


do not use else after return [readability-else-after-return]

else if(first== max) return span_type(extent0 , extent0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported as warning by clang-tidy.

github-actions · 2021-06-21T06:08:15Z

include/boost/numeric/ublas/tensor/subtensor_utility.hpp

+  else {
+    size_type step  = s.step ();
+    if(size == 0)        return span_type(0       , size_type(1), extent0);
+    else if(first== max) return span_type(extent0 , step, extent0);


do not use else after return [readability-else-after-return]

else if(first== max) return span_type(extent0 , step, extent0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported as warning by clang-tidy.

github-actions

Reports by clang tidy

github-actions · 2022-12-11T22:26:46Z

include/boost/numeric/ublas/tensor/span.hpp

+
+using sspan = span<std::size_t>;
+
+} // namespace


namespace boost::numeric::ublas ends with a comment that refers to a wrong namespace `` [google-readability-namespace-comments]

} // namespace ^~~~~~~~~~~~~ // namespace boost::numeric::ublas include/boost/numeric/ublas/tensor/span.hpp:25:11: note: namespace 'boost::numeric::ublas' starts here namespace boost::numeric::ublas { ^

Reported as warning by clang-tidy.

github-actions · 2022-12-11T22:26:46Z

include/boost/numeric/ublas/tensor/subtensor.hpp

+	BOOST_UBLAS_INLINE
+	subtensor (tensor_type& t)
+        : super_type    ()
+        , spans_        ()


initializer for member spans_ is redundant [readability-redundant-member-init]

, spans_ () ^~~~~~~~~~~~~~~~

Reported as warning by clang-tidy.

github-actions · 2022-12-11T22:26:46Z

include/boost/numeric/ublas/tensor/subtensor.hpp

+	}
+
+	template<typename ... span_types>
+    subtensor(tensor_type& t, span_types&& ... spans)


constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]

subtensor(tensor_type& t, span_types&& ... spans) ^ explicit

Reported as warning by clang-tidy.

github-actions · 2022-12-11T22:26:46Z

include/boost/numeric/ublas/tensor/subtensor.hpp

+    explicit
+    subtensor (tensor_type const& t)
+        : super_type    ()
+        , spans_        ()


initializer for member spans_ is redundant [readability-redundant-member-init]

, spans_ () ^~~~~~~~~~~~~~~~

Reported as warning by clang-tidy.

github-actions · 2022-12-11T22:26:47Z

include/boost/numeric/ublas/tensor/subtensor_utility.hpp

+
+    size_type step  = s.step ();
+    if(size == 0)                   return span_type(0       , 1u,   extent0);
+    else if(first== span_type::max) return span_type(extent0 , step, extent0);


do not use else after return [readability-else-after-return]

else if(first== span_type::max) return span_type(extent0 , step, extent0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported as warning by clang-tidy.

freifrauvonbleifrei · 2023-02-15T14:25:40Z

Hi, I just wanted to let you know that I would be interested in trying this feature!

github-actions · 2023-05-28T09:11:45Z

This Pull request Passed all of clang-tidy tests. 👍

amitsingh19975 added the enhancement label Jun 21, 2021

amitsingh19975 requested a review from bassoy June 21, 2021 05:32

amitsingh19975 assigned bassoy and amitsingh19975 Jun 21, 2021

github-actions bot reviewed Jun 21, 2021

View reviewed changes

bassoy force-pushed the develop branch from 254a3b1 to 09db8ba Compare September 9, 2021 12:45

Cem Bassoy and others added 8 commits December 11, 2022 19:11

rebase subtensor

f91fea9

add subtensor test

94ae6a7

add access functions for tensor and subtensor.

1513a07

stride creation changed.

64c661b

fix tesor-vector multiplication for subtensor.

ae385d4

improve product function for tensor-times-vector.

0df6293

remove difference between strides and slices.

949ffaa

fix wrong mtv call from test multiplication.

50e19e5

bassoy force-pushed the features/subtensor branch from 87ee607 to 50e19e5 Compare December 11, 2022 22:14

github-actions bot reviewed Dec 11, 2022

View reviewed changes

freifrauvonbleifrei mentioned this pull request Feb 17, 2023

Use boost::numeric::ublas::tensor as underlying data structure for DistributedFullGrid SGpp/DisCoTec#50

Closed

revert stride computation for vectors.

997df31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features/subtensor #126

Features/subtensor #126

amitsingh19975 commented Jun 21, 2021

github-actions bot left a comment

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot Jun 21, 2021

github-actions bot left a comment

github-actions bot Dec 11, 2022

github-actions bot Dec 11, 2022

github-actions bot Dec 11, 2022

github-actions bot Dec 11, 2022

github-actions bot Dec 11, 2022

freifrauvonbleifrei commented Feb 15, 2023

github-actions bot commented May 28, 2023

Features/subtensor #126

Are you sure you want to change the base?

Features/subtensor #126

Conversation

amitsingh19975 commented Jun 21, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 11, 2022

Choose a reason for hiding this comment

github-actions bot Dec 11, 2022

Choose a reason for hiding this comment

github-actions bot Dec 11, 2022

Choose a reason for hiding this comment

github-actions bot Dec 11, 2022

Choose a reason for hiding this comment

github-actions bot Dec 11, 2022

Choose a reason for hiding this comment

freifrauvonbleifrei commented Feb 15, 2023

github-actions bot commented May 28, 2023