Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yes: deal with UnicodeDecodeError in input(), fixes #6984 #8597

Conversation

ThomasWaldmann
Copy link
Member

if retry is True, it will just retry to get a valid answer. if retry is False, it will return the default.

the code can be tested by entering "error" (without the quotes).

if retry is True, it will just retry to get a valid answer.
if retry is False, it will return the default.

the code can be tested by entering "error" (without the quotes).
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (2230932) to head (f056403).
Report is 24 commits behind head on 1.4-maint.

Files with missing lines Patch % Lines
src/borg/helpers/yes.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #8597      +/-   ##
=============================================
+ Coverage      82.24%   82.56%   +0.31%     
=============================================
  Files             38       38              
  Lines          11076    11091      +15     
  Branches        2130     1716     -414     
=============================================
+ Hits            9110     9157      +47     
+ Misses          1390     1377      -13     
+ Partials         576      557      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit 7bf22bd into borgbackup:1.4-maint Dec 24, 2024
10 of 11 checks passed
@ThomasWaldmann ThomasWaldmann deleted the yesno-ignore-unicode-error-1.4 branch December 24, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant