Add suppressEmbeds and unsuppressEmbeds functions for CC
#1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t functional due to discordgo bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions enable the suppressing of embeds on messages not sent by YAGPDB via the SUPPRESS_EMBEDS flag.
The implementation should be functional if not for the bug discussed in bwmarrin/discordgo#1484 which is patched in bwmarrin/discordgo#1483. Discussion in the Discord was split on whether it is best to implement that solution in YAGPDB's discordgo library or to create an entirely new restapi function
ChannelMessageEditFlagsthat handles specifically editing only flags. Look around here if context is wanted. I marked the PR as a draft until some conclusion is reached on this.There has also been discussion of whether this should be part of
complexMessageEdit, but little of a consensus, so it isn't so far.I have tested it on messages sent by YAGPDB itself, both suppressing and unsuppressing embeds works.