Add unwarn modlog (with option on dashbord) #1795
Conversation
moderation/assets/moderation.html
Outdated
| @@ -472,6 +472,8 @@ <h4>Delete ALL server warnings?</h4> | |||
|
|
|||
| {{checkbox "WarnIncludeChannelLogs" "WarnIncludeChannelLogs" "Create message logs in the channel that the command was run in when a user is warned" .ModConfig.WarnIncludeChannelLogs}} | |||
| {{checkbox "WarnSendToModlog" "WarnSendToModlog" "Send warnings to the modlog" .ModConfig.WarnSendToModlog}} | |||
| {{checkbox "UnwarnSendToModlog" "UnwarnSendToModlog" "Send warning removal to the modlog" .ModConfig.UnwarnSendToModlog}} | |||
| {{checkbox "UnwarnIncludeWarnReason" "UnwarnIncludeWarnReason" "Include warning reason in the modlog" .ModConfig.UnwarnIncludeWarnReason}} | |||
There was a problem hiding this comment.
I’m not sure it’s immediately evident this is still referring to a warn removal.
There was a problem hiding this comment.
Mhh, the command being called deletewarning, it doesn't make sense at all
I'll change that
There was a problem hiding this comment.
Any idea on the text to show ?
There was a problem hiding this comment.
And in back, all renamed to Delwarnxxxxx to match the command name
There was a problem hiding this comment.
“Append original warn reason when removing” :maby:
There was a problem hiding this comment.
I don't like replacing "removing" by "deletion" but it matches the function....
There was a problem hiding this comment.
yep that makes sense to me
+ adding that warning has been deleted in the error messages
|
It is isn't still clear to me what this PR actually does and what is the purpose of it. Please showcase demo usage along with screenshots. |
You can see a demo here https://sh.col1n.fr/YAG-PR1795-demo.html |
|
I don't understand the purpose of displaying warn reason in the deletewarning entry. We don't do this with mutes or bans, so why do it here? |
|
At first, I wasn't going to add the original warn reason, but I was already getting the warn entry, and it can be useful for admins to quickly have the original reason without looking in the modlogs (which don't display the warnID) So if you delete a warning, there is no way for the admin to have the original reason |
|
If you delete a warning, you do so because you don't need it anymore. So why would you wanna have the original reason? Imo consistency amongst all commands should be favored over the little bit of effort it would take to look at the mod-logs to find the original reason if it is ever needed at all |
|
Fair point, I can remove that part (but modlog the delwarn is consistent) To complete Soggy's response : ID are not related to server, but are overall yag (> 150M currently)
|
|
I am against removal. If you’re unmuted, you know there’s only one mute they can be talking about. If you’re unbanned, there could only be one ban you’re talking about. If you delete a warning, there could be multiple warnings and you are only removing one. If the only identifier is a warning ID, it will be literally impossible to find which warning it is referring to without manually counting every warning ever issued on your server. |
Starting from https://discord.com/channels/166207328570441728/1316169654502293514
UnwarnSendToModlog: In the name
UnwarnIncludeWarnReason: Include the dbStored (not the modlog message) original warn reason
MAUnwarned = ModlogAction{Prefix: "Warn removed", Emoji: "🧽", Color: 0xfca253}
23/dec/2024 : I did found an old suggestion