Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagick: build with support for AVIF format by aom encoder #566

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

duswie
Copy link

@duswie duswie commented Nov 16, 2024

The Imagick build did not support the AVIF format due to missing encoder dependencies. Generated .avif files were empty without producing an error.

This is fixed by building imagick with upgraded and additional dependencies (AOM Encoder) and more extensive tests are added.

@duswie duswie changed the title Imagick: build with support for AVIF format with aim encoder Imagick: build with support for AVIF format by aom encoder Nov 16, 2024
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@mnapoli
Copy link
Member

mnapoli commented Dec 1, 2024

Does this increase the layer size by a lot?

@duswie
Copy link
Author

duswie commented Dec 4, 2024

It's ~100MB now.
Do you think this is reasonable, or should we make it a separate layer like “imagick-full”?
Bildschirmfoto 2024-12-04 um 20 10 41

@mnapoli
Copy link
Member

mnapoli commented Dec 4, 2024

Sorry I meant the Lambda layer (the zip file), not the Docker layers.

@duswie
Copy link
Author

duswie commented Dec 5, 2024

Got you. The compressed zip files size is only increased by 514kB (+ 1,5%) to 36,2 MB.

@Nyholm
Copy link
Collaborator

Nyholm commented Dec 11, 2024

Can you please rebase this and I'll be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants