Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume object hashes are unique in caching logic #215

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Dec 18, 2024

Fixes #214

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (735530a) to head (ae94fbf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          28       28           
  Lines        2296     2303    +7     
=======================================
+ Hits         2292     2299    +7     
  Misses          4        4           
Flag Coverage Δ
unittests 99.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi force-pushed the brent/fix_runtime_checkable_edge_case branch from 9db3348 to 48bacd1 Compare December 19, 2024 00:34
@brentyi brentyi force-pushed the brent/fix_runtime_checkable_edge_case branch from b04e523 to 27b24af Compare December 19, 2024 02:49
@brentyi brentyi changed the title Fix cache collision edge cases Don't assume object hashes are unique in caching logic Dec 19, 2024
@brentyi brentyi merged commit 6e9a049 into main Dec 19, 2024
16 checks passed
@brentyi brentyi deleted the brent/fix_runtime_checkable_edge_case branch December 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super weird edge case with runtime_checkable
1 participant