Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in PHPUnit test code. #2867 #2868

Closed
wants to merge 1 commit into from

Conversation

websuke
Copy link

@websuke websuke commented Oct 12, 2023

Fixes were made so that the test would pass.
Thank you for your confirmation.

@kylekatarnls
Copy link
Collaborator

Right now this test pass on both Windows and Linux on all PHP versions in GitHub Actions:
https://github.com/briannesbitt/Carbon/actions/runs/6486348590

(It's using PHPStan 1.10.38 as of now)

It also pass locally in my env.

So I would expect jobs to fail if we merge that.

You might have something different in your env.

@websuke
Copy link
Author

websuke commented Oct 12, 2023

@kylekatarnls
I have confirmed that it works on both my Mac and Ubuntu by modifying it, but the environment may be bad in both. We will close it. I apologize for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants