-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple size
dictionary from EinExprs
#45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `getproperty(x, :args)` to return the `EinExpr`s underneath.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 78.38% 80.23% +1.85%
==========================================
Files 11 12 +1
Lines 273 334 +61
==========================================
+ Hits 214 268 +54
- Misses 59 66 +7 ☔ View full report in Codecov by Sentry. |
BeforeBenchmarkTools.Trial: 10000 samples with 7 evaluations.
Range (min … max): 4.696 μs … 309.470 μs ┊ GC (min … max): 0.00% … 96.32%
Time (median): 4.935 μs ┊ GC (median): 0.00%
Time (mean ± σ): 5.269 μs ± 9.726 μs ┊ GC (mean ± σ): 6.01% ± 3.20%
▁▃▄ ▆▇█▇ ▅▃▃
▁▁▁▁▁▁▁▁▂▁▃▃▄▅▃▇███▇█████████▄▆▅▃▃▂▂▂▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ▃
4.7 μs Histogram: frequency by time 5.33 μs <
Memory estimate: 7.27 KiB, allocs estimate: 160. AfterBenchmarkTools.Trial: 10000 samples with 10 evaluations.
Range (min … max): 1.913 μs … 252.412 μs ┊ GC (min … max): 0.00% … 97.77%
Time (median): 1.988 μs ┊ GC (median): 0.00%
Time (mean ± σ): 2.117 μs ± 5.519 μs ┊ GC (mean ± σ): 5.74% ± 2.18%
▁▂▄ ▅▇▇▇ █▇▆▅ ▄▃▂▂
▂▂▂▂▂▁▃▃▄▅▁▆████▁████▁████▁█████▁▇▆▅▅▁▄▄▃▃▁▃▂▂▂▂▁▂▂▂▂▁▂▂▂▂▂ ▄
1.91 μs Histogram: frequency by time 2.11 μs <
Memory estimate: 2.39 KiB, allocs estimate: 43. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manipulating
EinExpr
s (e.g. creating, summing, ...), creation and merge ofsize
dictionaries incurs into a large amount of allocations.This PR decouples
size
dictionary fromEinExpr
and introducesSizedEinExpr
: aEinExpr
wrapper with a global index size dictionary.Before
After