Require GraphMakie explicitly to plot
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn user if `Makie` installed but not `GraphMakie`
mofeing
force-pushed
the
refactor/graphmakie-requirement
branch
from
7022922 to
2ee795e
Compare
|
As agreed in the chat, we'll merge this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 76.92% 76.90% -0.02%
==========================================
Files 12 13 +1
Lines 390 394 +4
==========================================
+ Hits 300 303 +3
- Misses 90 91 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing without using it
Makieis a huge burden currently. Its precompilation time last minutes. While TTFT has improved significantly in the last Julia versions, first time users or developers while editing may encounter big delays due toMakie.The ideal solution would be to add strong-dependencies to package extensions, but this is not ready yet (not even considered, but see https://julialang.slack.com/archives/C67910KEH/p1702027275166039 for more information).
I decided to go on the line of
Fluxand warn the user to explicitly installGraphMakie.